Skip to content

[EMCAL-507] Setting default files for objects handled by ROOTTreeReader#7355

Merged
shahor02 merged 1 commit into
AliceO2Group:devfrom
mfasDa:EMCAL-507
Nov 1, 2021
Merged

[EMCAL-507] Setting default files for objects handled by ROOTTreeReader#7355
shahor02 merged 1 commit into
AliceO2Group:devfrom
mfasDa:EMCAL-507

Conversation

@mfasDa
Copy link
Copy Markdown
Collaborator

@mfasDa mfasDa commented Oct 18, 2021

No description provided.

@mfasDa
Copy link
Copy Markdown
Collaborator Author

mfasDa commented Oct 20, 2021

blocked by AliceO2Group/QualityControl#917

@mfasDa mfasDa requested a review from shahor02 October 20, 2021 10:23
Copy link
Copy Markdown
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfasDa the CI errors are genuine

@mfasDa
Copy link
Copy Markdown
Collaborator Author

mfasDa commented Oct 27, 2021

@shahor02 Yes, this is known. As stated above we had a dedicated qc workflow for EMCAL for initial development due to problems with workflow chaining in the early time, which is now legacy and no longer used as chaining works smoothly, but depends on the publisher interface, which is changed by this commit. The change that removes the dedicated EMCAL QC workflow in QualityControl is already merged but not yet tagged. @Barthelemy for reference. I expect new tags will only come after the pilot beam, not sure how urgent this change is.

@mfasDa
Copy link
Copy Markdown
Collaborator Author

mfasDa commented Nov 1, 2021

@shahor02 The commit in QualityControl is tagged now so this PR can be processed. I see the only test failing is the fullCI, which is unrelated to the commit. I think this can be merged now.

@shahor02 shahor02 merged commit 6a530bf into AliceO2Group:dev Nov 1, 2021
@mfasDa mfasDa deleted the EMCAL-507 branch November 1, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants